-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue in using dplr with hybrid/scaled pair_style #4273
Comments
I've read the related LAMMPS code. It seems when there are more than one deepmd pairs match, and no index is assigned, no pair is returned. I am not sure whether it is okay to set index to 1 or an argument for index should be passed in this case. |
…airs Fix deepmodeling#4273. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Thank you very much for adding this new feature into the fix_dplr. I am testing this new feature. |
…airs (#4274) Fix #4273. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new optional keyword `pair_deepmd_index` in the `fix dplr` command for enhanced control in simulations. - Updated documentation with clearer instructions and examples for the DPLR model, including training process and simulation setup. - **Bug Fixes** - Improved error handling related to the new `pair_deepmd_index` parameter to ensure proper usage. - **Documentation** - Enhanced descriptions and usability of the DPLR model documentation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
It looks unrelated. If you find bugs, please open a new issue. |
keys.push_back("pair_deepmd_index") should be added in the fix_dplr.cpp to activate the new parameter "pair_deepmd_index" |
Thank you for reporting the bug. Did it work after it is added? |
it works. Thank you for your help
…---- Replied Message ----
| From | Jinzhe ***@***.***> |
| Date | 11/05/2024 15:35 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [deepmodeling/deepmd-kit] issue in using dplr with hybrid/scaled pair_style (Issue #4273) |
keys.push_back("pair_deepmd_index") should be added in the fix_dplr.cpp to activate the new parameter "pair_deepmd_index"
Thank you for reporting the bug. Did it work after it is added?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
…lr.cpp` Fix deepmodeling#4273. * Modify `is_key` function to include `keys.push_back("pair_deepmd_index")` Update tests in `test_dplr.py` to include `pair_deepmd_index` command * Add `pair_deepmd_index 0` to various `lammps.fix` commands in the test cases
…4313) Fix #4273. Tests are added in this PR. * Modify `is_key` function to include `keys.push_back("pair_deepmd_index")` Update tests in `test_dplr.py` to include `pair_deepmd_index` command * Add `pair_deepmd_index 0` to various `lammps.fix` commands in the test cases <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new key, `pair_deepmd_index`, enhancing the `FixDPLR` class for improved pair validation in simulations. - **Bug Fixes** - Updated error handling to ensure robustness when the new `pair_deepmd_index` is not provided. - **Tests** - Modified test parameters to include `pair_deepmd_index 0`, ensuring compatibility with the new functionality while maintaining existing validations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
When using dplr with hybrid/scaled pair_style to combining two dplr models, fix_dplr can not be used to define all dplr models.
input:
log.lammps:
The text was updated successfully, but these errors were encountered: