Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API: support fparam and aparam for DeepPot #2415

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 20, 2023

No description provided.

njzjz added 4 commits March 20, 2023 02:42
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the C label Mar 20, 2023
@njzjz njzjz changed the title support fparam and aparam for C API C API: support fparam and aparam for DeepPot Mar 20, 2023
@njzjz
Copy link
Member Author

njzjz commented Mar 20, 2023

Some extra effort is still required for DeepPotModelDevi.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 86.90% and project coverage change: +0.04 🎉

Comparison is base (bf0e0a1) 75.18% compared to head (0e425fe) 75.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2415      +/-   ##
==========================================
+ Coverage   75.18%   75.23%   +0.04%     
==========================================
  Files         223      223              
  Lines       22502    22574      +72     
  Branches     1658     1669      +11     
==========================================
+ Hits        16919    16984      +65     
  Misses       4505     4505              
- Partials     1078     1085       +7     
Impacted Files Coverage Δ
source/api_c/src/c_api.cc 78.76% <86.20%> (+0.24%) ⬆️
source/api_c/include/deepmd.hpp 89.71% <87.27%> (-1.20%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit ced9fdb into deepmodeling:devel Mar 21, 2023
nahso pushed a commit to HPC-AI-Team/deepmd-kit-se_atten-models that referenced this pull request Apr 12, 2023
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants