Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model-devi with mixed_type format #2433

Merged
merged 4 commits into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions deepmd/infer/deep_pot.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,16 @@ def __init__(
except (ValueError, KeyError):
self.modifier_type = None

try:
t_jdata = self._get_tensor("train_attr/training_script:0")
jdata = run_sess(self.sess, t_jdata).decode("UTF-8")
import json

jdata = json.loads(jdata)
self.descriptor_type = jdata["model"]["descriptor"]["type"]
except (ValueError, KeyError):
self.descriptor_type = None

if self.modifier_type == "dipole_charge":
t_mdl_name = self._get_tensor("modifier_attr/mdl_name:0")
t_mdl_charge_map = self._get_tensor("modifier_attr/mdl_charge_map:0")
Expand Down Expand Up @@ -243,6 +253,10 @@ def get_sel_type(self) -> List[int]:
"""Unsupported in this model."""
raise NotImplementedError("This model type does not support this attribute")

def get_descriptor_type(self) -> List[int]:
"""Get the descriptor type of this model."""
return self.descriptor_type

def get_dim_fparam(self) -> int:
"""Get the number (dimension) of frame parameters of this DP."""
return self.dfparam
Expand Down
12 changes: 10 additions & 2 deletions deepmd/infer/model_devi.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ def calc_model_devi(
models,
fname=None,
frequency=1,
mixed_type=False,
):
"""Python interface to calculate model deviation.

Expand All @@ -160,6 +161,8 @@ def calc_model_devi(
File to dump results, default None
frequency : int
Steps between frames (if the system is given by molecular dynamics engine), default 1
mixed_type : bool
Whether the input atype is in mixed_type format or not

Returns
-------
Expand Down Expand Up @@ -187,6 +190,7 @@ def calc_model_devi(
coord,
box,
atype,
mixed_type=mixed_type,
)
energies.append(ret[0] / natom)
forces.append(ret[1])
Expand Down Expand Up @@ -246,17 +250,21 @@ def make_model_devi(
for system in all_sys:
# create data-system
dp_data = DeepmdData(system, set_prefix, shuffle_test=False, type_map=tmap)
mixed_type = dp_data.mixed_type

data_sets = [dp_data._load_set(set_name) for set_name in dp_data.dirs]
nframes_tot = 0
devis = []
for data in data_sets:
coord = data["coord"]
box = data["box"]
atype = data["type"][0]
if mixed_type:
atype = data["type"]
else:
atype = data["type"][0]
if not dp_data.pbc:
box = None
devi = calc_model_devi(coord, box, atype, dp_models)
devi = calc_model_devi(coord, box, atype, dp_models, mixed_type=mixed_type)
njzjz marked this conversation as resolved.
Show resolved Hide resolved
nframes_tot += coord.shape[0]
devis.append(devi)
devis = np.vstack(devis)
Expand Down
Loading