Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add links to documentation in LAMMPS input #2453

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 11, 2023

Closes #2425.

It takes work to explain everything in the comment. So, instead, I add a link to the documentation.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ad8536f) 75.22% compared to head (67c2a49) 75.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2453   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files         223      223           
  Lines       22691    22691           
  Branches     1659     1673   +14     
=======================================
+ Hits        17069    17070    +1     
+ Misses       4526     4525    -1     
  Partials     1096     1096           

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm
Copy link
Collaborator

wanghan-iapcm commented Apr 12, 2023

The link does not work.
We did not say that the type map is optional in the pair_coeff command.

@njzjz
Copy link
Member Author

njzjz commented Apr 12, 2023

The link does not work. We did not say that the type map is optional in the pair_coeff command.

We gave the following sentence in the documentation:

If atom names are not set in the pair_coeff command, the training parameter type_map will be used by default.

Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm merged commit 00deb3e into deepmodeling:devel Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitee | deepmodeling/deepmd-kit | 新任务 #I6Q34W | The pair_coeff in lammps input file for dp 2.0.2
2 participants