support combining frozen models into a pairwise DPRc model #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> (cherry picked from commit c7f38fee421bf90f779cb84d1ecc7fb9edd69a97)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #2902 +/- ##
==========================================
- Coverage 75.49% 75.49% -0.01%
==========================================
Files 244 244
Lines 24569 24571 +2
Branches 1580 1580
==========================================
+ Hits 18548 18549 +1
- Misses 5090 5091 +1
Partials 931 931
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "frozen" model has been previously supported in #2781, so this PR allows it to be used in the pairwise DPRc model.$N$ type maps of the whole models, as the QM model doesn't need MM types.
Allow QM model type maps to be just the first
One can load two separated models into one model or load the existing QM model and train the rest of the model.