Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc: reimplement read_file_to_string without calling TensorFlow #3176

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 24, 2024

LAMMPS is using it

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the C++ label Jan 24, 2024
@njzjz njzjz requested a review from wanghan-iapcm January 24, 2024 20:53
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ee3f4c) 28.06% compared to head (53104df) 76.09%.

Files Patch % Lines
source/api_cc/src/common.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #3176       +/-   ##
===========================================
+ Coverage   28.06%   76.09%   +48.03%     
===========================================
  Files         250      283       +33     
  Lines       22919    25690     +2771     
  Branches     1591     1592        +1     
===========================================
+ Hits         6432    19549    +13117     
+ Misses      15790     5216    -10574     
- Partials      697      925      +228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 663e4a8 into deepmodeling:devel Jan 25, 2024
46 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants