Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: move deepmd_utils to deepmd #3178

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 25, 2024

No description provided.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz added the breaking change Breaking changes that should notify users. label Jan 25, 2024
@@ -11,6 +11,7 @@

import numpy as np

from deepmd.infer.deep_pot import DeepPot as DeepPotBase

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.infer.deep_pot
begins an import cycle.
Comment on lines +14 to +18
from deepmd.main import (
get_ll,
main_parser,
parse_args,
)

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.main
begins an import cycle.
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5b9dd3d) 76.09% compared to head (5fb5af3) 76.08%.

Files Patch % Lines
deepmd/__main__.py 0.00% 4 Missing ⚠️
deepmd/tf/loggers/loggers.py 0.00% 2 Missing ⚠️
deepmd/tf/common.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3178      +/-   ##
==========================================
- Coverage   76.09%   76.08%   -0.02%     
==========================================
  Files         284      284              
  Lines       25695    25699       +4     
  Branches     1592     1592              
==========================================
  Hits        19552    19552              
- Misses       5218     5222       +4     
  Partials      925      925              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz requested a review from wanghan-iapcm January 25, 2024 05:38
@wanghan-iapcm wanghan-iapcm merged commit 3618702 into deepmodeling:devel Jan 25, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking changes that should notify users. Docs LAMMPS Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants