Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build macos-arm64 wheel on M1 runners #3206

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 31, 2024

Today GitHub introduced the new M1 runners, making it possible to build macos-arm64 wheels without cross-building.

Remove old hacked codes for cross-building.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b800043) 74.22% compared to head (826071e) 74.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3206      +/-   ##
==========================================
+ Coverage   74.22%   74.32%   +0.09%     
==========================================
  Files         313      344      +31     
  Lines       27343    31873    +4530     
  Branches      908     1592     +684     
==========================================
+ Hits        20296    23690    +3394     
- Misses       6510     7258     +748     
- Partials      537      925     +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz requested a review from wanghan-iapcm January 31, 2024 00:49
@wanghan-iapcm wanghan-iapcm merged commit 664c70b into deepmodeling:devel Jan 31, 2024
45 checks passed
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Feb 4, 2024
Today [GitHub introduced the new M1
runners](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/),
making it possible to build macos-arm64 wheels without cross-building.

Remove old hacked codes for cross-building.

(cherry picked from commit 664c70b)
wanghan-iapcm pushed a commit that referenced this pull request Feb 4, 2024
Today [GitHub introduced the new M1
runners](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/),
making it possible to build macos-arm64 wheels without cross-building.

Remove old hacked codes for cross-building.

(cherry picked from commit 664c70b)
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants