Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop deepmd.tf.cluster.slurm #3239

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 5, 2024

The deepmd.tf.cluster.slurm is too specialized - we are not able to support every cluster. This PR uses mpi4py as the alternatives, considering the documentation has asked users to install mpi4py.

The `deepmd.tf.cluster.slurm` is too specialized - we are not able to support every cluster. This PR uses mpi4py as the alternatives, considering the documentation has asked users to install mpi4py.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm February 5, 2024 23:12
@github-actions github-actions bot added the Python label Feb 5, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f5bb131) 21.19% compared to head (3ac0808) 74.95%.

Files Patch % Lines
deepmd/utils/hostlist.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #3239       +/-   ##
===========================================
+ Coverage   21.19%   74.95%   +53.76%     
===========================================
  Files         363      363               
  Lines       32545    32550        +5     
  Branches     1608     1608               
===========================================
+ Hits         6898    24399    +17501     
+ Misses      25086     7278    -17808     
- Partials      561      873      +312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 6672a28 into deepmodeling:devel Feb 6, 2024
46 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants