Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: infer model type from ModelOutputDef #3250

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 9, 2024

No description provided.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the Python label Feb 9, 2024
Comment on lines +21 to +23
from deepmd.infer.deep_dipole import (
DeepDipole,
)

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.infer.deep_dipole
begins an import cycle.
Comment on lines +24 to +26
from deepmd.infer.deep_dos import (
DeepDOS,
)

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.infer.deep_dos
begins an import cycle.
from deepmd.infer.deep_dos import (
DeepDOS,
)
from deepmd.infer.deep_eval import DeepEval as DeepEvalWrapper

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.infer.deep_eval
begins an import cycle.
Comment on lines +31 to +34
from deepmd.infer.deep_polar import (
DeepGlobalPolar,
DeepPolar,
)

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.infer.deep_polar
begins an import cycle.
Comment on lines +38 to +40
from deepmd.infer.deep_wfc import (
DeepWFC,
)

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
deepmd.infer.deep_wfc
begins an import cycle.
@njzjz njzjz requested a review from wanghan-iapcm February 9, 2024 00:20
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (c235099) 75.19% compared to head (d302a5a) 75.16%.

Files Patch % Lines
deepmd/pt/infer/deep_eval.py 25.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3250      +/-   ##
==========================================
- Coverage   75.19%   75.16%   -0.03%     
==========================================
  Files         372      372              
  Lines       33136    33155      +19     
  Branches     1608     1608              
==========================================
+ Hits        24916    24922       +6     
- Misses       7347     7360      +13     
  Partials      873      873              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit d1d7881 into deepmodeling:devel Feb 9, 2024
46 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants