breaking: pt: remove data preprocess from data stat #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore deepmodeling#3233 with resolved conflicts and conversations.
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
iProzd
requested review from
njzjz,
CaRoLZhangxy,
wanghan-iapcm and
Chengqian-Zhang
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3261 +/- ##
==========================================
- Coverage 75.27% 74.82% -0.46%
==========================================
Files 373 373
Lines 33252 33040 -212
Branches 1604 1604
==========================================
- Hits 25032 24721 -311
- Misses 7349 7448 +99
Partials 871 871 ☔ View full report in Codecov by Sentry. |
njzjz
reviewed
Feb 11, 2024
CaRoLZhangxy
approved these changes
Feb 12, 2024
wanghan-iapcm
requested changes
Feb 12, 2024
njzjz
approved these changes
Feb 12, 2024
Chengqian-Zhang
approved these changes
Feb 13, 2024
wanghan-iapcm
approved these changes
Feb 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Remove data preprocess from data stat.
Cleanup dependency of data preprocess in dataset and dataloader.
Note that:
DeepmdDataSystemstill has dependency for PyTorch, which leaves for @CaRoLZhangxy to clean up.Denoise part in
DeepmdDataSystemstill needs further clean up, which leaves for @Chengqian-Zhang.