Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add polarizability fitting net #3296

Merged
merged 33 commits into from
Feb 20, 2024
Merged

Conversation

anyangml
Copy link
Collaborator

@anyangml anyangml commented Feb 19, 2024

This PR is to provide pytorch implementation and backend-independent numpy implementation of the polarizability fitting net.

Note:

  • The shift_diag requires statistics, not implemented in this PR.

@anyangml anyangml self-assigned this Feb 19, 2024
@wanghan-iapcm
Copy link
Collaborator

#3289 will be merged before this PR.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ab2ed0e) 75.05% compared to head (02db689) 75.11%.

Files Patch % Lines
deepmd/dpmodel/fitting/polarizability_fitting.py 89.09% 6 Missing ⚠️
deepmd/dpmodel/fitting/general_fitting.py 75.00% 2 Missing ⚠️
deepmd/pt/model/task/fitting.py 66.66% 2 Missing ⚠️
deepmd/pt/model/task/polarizability.py 98.03% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3296      +/-   ##
==========================================
+ Coverage   75.05%   75.11%   +0.05%     
==========================================
  Files         396      398       +2     
  Lines       33895    34010     +115     
  Branches     1604     1604              
==========================================
+ Hits        25441    25545     +104     
- Misses       7593     7604      +11     
  Partials      861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml marked this pull request as draft February 19, 2024 03:14
@anyangml anyangml added the Test CUDA Trigger test CUDA workflow label Feb 19, 2024
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Feb 19, 2024
@anyangml anyangml marked this pull request as ready for review February 19, 2024 07:49
deepmd/dpmodel/fitting/polarizability_fitting.py Outdated Show resolved Hide resolved
deepmd/pt/model/task/fitting.py Outdated Show resolved Hide resolved
deepmd/pt/model/task/polarizability.py Outdated Show resolved Hide resolved
@anyangml anyangml requested a review from njzjz February 19, 2024 11:13
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 20, 2024
This PR is to provide pytorch implementation and backend-independent
numpy implementation of the polarizability fitting net.

Note:
- The shift_diag requires statistics, not implemented in this PR.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged via the queue into deepmodeling:devel with commit 33495d8 Feb 20, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants