Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert model files between backends #3323

Merged
merged 11 commits into from
Feb 23, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 22, 2024

dp convert-backend model.pb model.pth
dp convert-backend model.pb model.dp

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 80.27211% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 75.33%. Comparing base (cf21b7a) to head (df642da).

Files Patch % Lines
deepmd/pt/utils/serialization.py 64.51% 11 Missing ⚠️
deepmd/entrypoints/convert_backend.py 0.00% 8 Missing ⚠️
deepmd/tf/utils/serialization.py 89.58% 5 Missing ⚠️
deepmd/entrypoints/main.py 0.00% 3 Missing ⚠️
deepmd/backend/backend.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3323      +/-   ##
==========================================
+ Coverage   75.28%   75.33%   +0.04%     
==========================================
  Files         403      406       +3     
  Lines       33888    34025     +137     
  Branches     1604     1604              
==========================================
+ Hits        25514    25632     +118     
- Misses       7513     7532      +19     
  Partials      861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model_param may be confused with the trainable model parameters. I would suggest using more self-explanatory names like model_def_script.

deepmd/pt/utils/serialization.py Outdated Show resolved Hide resolved
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm February 22, 2024 20:30
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 23, 2024
Merged via the queue into deepmodeling:devel with commit d949bc8 Feb 23, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants