Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store type in descriptor serialization data #3325

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 22, 2024

No description provided.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 75.35%. Comparing base (d949bc8) to head (7421879).
Report is 1 commits behind head on devel.

Files Patch % Lines
deepmd/dpmodel/descriptor/make_base_descriptor.py 85.00% 3 Missing ⚠️
deepmd/common.py 60.00% 2 Missing ⚠️
deepmd/pt/model/descriptor/descriptor.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3325      +/-   ##
==========================================
+ Coverage   75.33%   75.35%   +0.02%     
==========================================
  Files         406      406              
  Lines       34047    34074      +27     
  Branches     1604     1604              
==========================================
+ Hits        25650    25678      +28     
+ Misses       7536     7535       -1     
  Partials      861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz
Copy link
Member Author

njzjz commented Feb 22, 2024

Something wrong in the CI:

  Importing GPG key 0xC21AD6EA:
   Userid     : "AlmaLinux <packager@almalinux.org>"
   Fingerprint: E53C F5EF 91CE B0AD 1812 ECB8 51D6 647E C21A D6EA
   From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Key imported successfully
  Import of key(s) didn't help, wrong key(s)?
  Public key for glibc-gconv-extra-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-gconv-extra-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for glibc-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for glibc-common-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-common-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for glibc-devel-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-devel-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for glibc-headers-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-headers-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for glibc-langpack-en-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-langpack-en-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for glibc-locale-source-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-locale-source-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for glibc-minimal-langpack-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: glibc-minimal-langpack-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  Public key for libnsl-2.28-236.el8_9.12.x86_64.rpm is not installed. Failing package is: libnsl-2.28-236.el8_9.12.x86_64
   GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-AlmaLinux
  The downloaded packages were saved in cache until the next successful transaction.
  You can remove cached packages by executing 'yum clean packages'.
  Error: GPG check FAILED
                                                             ✕ 19.99s

github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
This seems to fix the GPG key error posted at
#3325 (comment).
See https://almalinux.org/blog/2023-12-20-almalinux-8-key-update/

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm February 23, 2024 06:17
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 23, 2024
Merged via the queue into deepmodeling:devel with commit 649fdca Feb 23, 2024
48 checks passed
@njzjz njzjz linked an issue Mar 1, 2024 that may be closed by this pull request
3 tasks
@njzjz njzjz mentioned this pull request Apr 2, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Apr 6, 2024
This seems to fix the GPG key error posted at
deepmodeling#3325 (comment).
See https://almalinux.org/blog/2023-12-20-almalinux-8-key-update/

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit d7a4f72)
njzjz added a commit that referenced this pull request Apr 6, 2024
This seems to fix the GPG key error posted at
#3325 (comment).
See https://almalinux.org/blog/2023-12-20-almalinux-8-key-update/

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit d7a4f72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialize should contain type information
2 participants