Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_dplr.cpp delete redundant setup #3344

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix_dplr.cpp delete redundant setup #3344

merged 2 commits into from
Feb 27, 2024

Conversation

shiruosong
Copy link
Contributor

@shiruosong shiruosong commented Feb 27, 2024

Redundant setup was removed. The setup has already been executed in the initial lines of post_force, along with subsequent calculations. Reinitialization will lead to an error.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (3e6b507) to head (42fa1c0).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3344   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files         408      408           
  Lines       34246    34243    -3     
  Branches     1604     1603    -1     
=======================================
- Hits        25875    25874    -1     
+ Misses       7510     7509    -1     
+ Partials      861      860    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiruosong shiruosong changed the title fix_dplr.cpp delete additional setup fix_dplr.cpp delete redundant setup Feb 27, 2024
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 27, 2024
Merged via the queue into deepmodeling:devel with commit 254afc8 Feb 27, 2024
48 checks passed
@shiruosong shiruosong deleted the dplr-setup-bugfix branch February 29, 2024 08:46
@njzjz njzjz added this to the v2.2.10 milestone Mar 17, 2024
@njzjz njzjz mentioned this pull request Apr 2, 2024
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Apr 6, 2024
Redundant setup was removed. The setup has already been executed in the
initial lines of post_force, along with subsequent calculations.
Reinitialization will lead to an error.

(cherry picked from commit 254afc8)
@njzjz njzjz mentioned this pull request Apr 6, 2024
njzjz pushed a commit that referenced this pull request Apr 6, 2024
Redundant setup was removed. The setup has already been executed in the
initial lines of post_force, along with subsequent calculations.
Reinitialization will lead to an error.

(cherry picked from commit 254afc8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants