Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @version to serialization data #3349

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 27, 2024

At this time, all current versions and the minimal and maximum versions are set to 1. If any changes, whether breaking or not, are made to the serialization data, the version should be bumped.

At this time, all current versions and the minimal and maximum versions are set to 1. If any changes, whether breaking or not, are made to the serialization data, the version should be bumped.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 98.50746% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.69%. Comparing base (004ebd6) to head (47bfd4a).

Files Patch % Lines
deepmd/utils/version.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3349      +/-   ##
==========================================
+ Coverage   75.64%   75.69%   +0.04%     
==========================================
  Files         411      412       +1     
  Lines       34569    34635      +66     
  Branches     1599     1603       +4     
==========================================
+ Hits        26151    26216      +65     
- Misses       7558     7559       +1     
  Partials      860      860              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm
Copy link
Collaborator

What kind of convention shall we adapt to numbering the model version?
shall we support separate version control for fine-grained modules? imagine the case that the descriptor of a model may be used to initialized the descriptor of another model.

@njzjz
Copy link
Member Author

njzjz commented Feb 28, 2024

What kind of convention shall we adapt to numbering the model version?

The version should be bumped when compatibility is broken with either forward or backward.

shall we support separate version control for fine-grained modules? imagine the case that the descriptor of a model may be used to initialized the descriptor of another model.

I think we should support separate versions for each serialize and deserialize method, which is the most convenient for developers.

njzjz and others added 2 commits February 27, 2024 20:38
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 28, 2024
Merged via the queue into deepmodeling:devel with commit f8ad655 Feb 28, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants