-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add @version to serialization data #3349
Conversation
At this time, all current versions and the minimal and maximum versions are set to 1. If any changes, whether breaking or not, are made to the serialization data, the version should be bumped. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3349 +/- ##
==========================================
+ Coverage 75.64% 75.69% +0.04%
==========================================
Files 411 412 +1
Lines 34569 34635 +66
Branches 1599 1603 +4
==========================================
+ Hits 26151 26216 +65
- Misses 7558 7559 +1
Partials 860 860 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
What kind of convention shall we adapt to numbering the model version? |
The version should be bumped when compatibility is broken with either forward or backward.
I think we should support separate versions for each |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
At this time, all current versions and the minimal and maximum versions are set to 1. If any changes, whether breaking or not, are made to the serialization data, the version should be bumped.