Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: apply type_one_side=True to se_a and se_r #3364

Merged
merged 1 commit into from
Feb 29, 2024
Merged

docs: apply type_one_side=True to se_a and se_r #3364

merged 1 commit into from
Feb 29, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 29, 2024

Fix #2265.

@njzjz
docs: apply type_one_side=True to se_a and se_r
e6c7e9f 
Fix deepmodeling#2265.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm February 29, 2024 04:13
@njzjz njzjz linked an issue Feb 29, 2024 that may be closed by this pull request
[Feature Request] Changing the default value of type_one_side to True #2265
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.90%. Comparing base (581dea3) to head (e6c7e9f).

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel    #3364   +/-   ##
=======================================
  Coverage   75.90%   75.90%           
=======================================
  Files         416      416           
  Lines       34981    34981           
  Branches     1614     1614           
=======================================
  Hits        26554    26554           
  Misses       7559     7559           
  Partials      868      868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 29, 2024
Merged via the queue into deepmodeling:devel with commit 84d0576 Feb 29, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
@njzjz njzjz added this to the v2.2.10 milestone Apr 6, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Apr 6, 2024
@njzjz
docs: apply type_one_side=True to se_a and se_r (deepmodeling#3364)
1bf218d 
Fix deepmodeling#2265.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit 84d0576)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this pull request Apr 6, 2024
Merged
njzjz added a commit that referenced this pull request Apr 6, 2024
@njzjz
docs: apply type_one_side=True to se_a and se_r (#3364)
ea3a3fd 
Fix #2265.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit 84d0576)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees
No one assigned
Labels
Docs Examples
Projects
None yet
Milestone
v2.2.10
Development

Successfully merging this pull request may close these issues.

[Feature Request] Changing the default value of type_one_side to True
2 participants
@njzjz @wanghan-iapcm