Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trainable settings for pt #3371

Merged
merged 7 commits into from
Mar 2, 2024
Merged

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented Mar 1, 2024

No description provided.

@github-actions github-actions bot added the Python label Mar 1, 2024
@iProzd iProzd requested review from njzjz and wanghan-iapcm March 1, 2024 02:03
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (ee8b82b) to head (f50afb5).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3371   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files         420      420           
  Lines       35683    35679    -4     
  Branches     1620     1620           
=======================================
- Hits        27323    27320    -3     
+ Misses       7492     7491    -1     
  Partials      868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add UT for this parameter?

iProzd added 2 commits March 1, 2024 23:58
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
@iProzd iProzd requested a review from wanghan-iapcm March 1, 2024 16:30
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 2, 2024
Merged via the queue into deepmodeling:devel with commit bdea3ce Mar 2, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
@iProzd iProzd deleted the add_trainable branch April 24, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants