Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_ckpt_keep for trainer #3441

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented Mar 9, 2024

No description provided.

@iProzd iProzd requested a review from njzjz March 9, 2024 09:34
@github-actions github-actions bot added the Python label Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.02%. Comparing base (a9bcf41) to head (88efeaa).

Files Patch % Lines
deepmd/pt/train/training.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3441   +/-   ##
=======================================
  Coverage   77.01%   77.02%           
=======================================
  Files         427      427           
  Lines       36790    36798    +8     
  Branches     1621     1621           
=======================================
+ Hits        28335    28342    +7     
- Misses       7587     7588    +1     
  Partials      868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but a typo in doc

deepmd/utils/argcheck.py Outdated Show resolved Hide resolved
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
@iProzd iProzd enabled auto-merge March 9, 2024 10:20
@iProzd iProzd added this pull request to the merge queue Mar 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2024
@iProzd iProzd added this pull request to the merge queue Mar 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2024
@iProzd iProzd added this pull request to the merge queue Mar 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2024
@njzjz njzjz added this pull request to the merge queue Mar 9, 2024
Merged via the queue into deepmodeling:devel with commit fd82f04 Mar 9, 2024
48 checks passed
@iProzd iProzd deleted the max_ckpt_keep branch March 28, 2024 07:40
@njzjz njzjz mentioned this pull request Apr 2, 2024
@njzjz njzjz added this to the v2.2.10 milestone Apr 6, 2024
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Apr 6, 2024
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit fd82f04)

--------

Code for PyTorch is removed.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this pull request Apr 6, 2024
njzjz pushed a commit that referenced this pull request Apr 6, 2024
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit fd82f04)

--------

Code for PyTorch is removed.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants