Fix LAMMPS plugin symlink path on macOS platform #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3473 +/- ##
=======================================
Coverage 77.49% 77.49%
=======================================
Files 432 432
Lines 37161 37161
Branches 1620 1620
=======================================
Hits 28797 28797
Misses 7496 7496
Partials 868 868 ☔ View full report in Codecov by Sentry. |
|
I'll first add this patch to conda-forge to see if the tests pass. (It's a known issue but I don't have a Mac to debug) |
njzjz
added a commit
to njzjz/deepmd-kit-feedstock
that referenced
this pull request
Mar 17, 2024
5 tasks
|
OK. If you have a Linux machine please also check if it breaks the Linux build. |
njzjz
approved these changes
Mar 17, 2024
Closed
njzjz
pushed a commit
to njzjz/deepmd-kit
that referenced
this pull request
Apr 6, 2024
This pull request fixes the broken symlink for `dpplugin.so` on macOS. It should point to `libdeepmd_lmp.so` but point to `libdeepmd_lmp.dylib` instead. ### Details The `libdeepmd_lmp` is a shared module. https://github.com/deepmodeling/deepmd-kit/blob/b875ea8f6661b6e1567537ead7e2b4a8b14ea113/source/lmp/plugin/CMakeLists.txt#L72 The build target name on macOS is `libdeepmd_lmp.so`. Because on macOS, the `CMAKE_SHARED_MODULE_SUFFIX` (`.so`) is different from `CMAKE_SHARED_LIBRARY_SUFFIX` (`.dynlib`). As a result, in previous versions, on macOS the symbolic link `dpplugin.so` was pointed to `libdeepmd_lmp.dylib`, which does not exist. One can check the conda-forge builds to confirm (e.g., [osx-arm64/deepmd-kit-2.2.9-cpu_py311hf5376d5_mpi_openmpi_0.conda](https://anaconda.org/conda-forge/deepmd-kit/2.2.9/download/osx-arm64/deepmd-kit-2.2.9-cpu_py311hf5376d5_mpi_openmpi_0.conda)). (cherry picked from commit abf3477)
Merged
njzjz
pushed a commit
that referenced
this pull request
Apr 6, 2024
This pull request fixes the broken symlink for `dpplugin.so` on macOS. It should point to `libdeepmd_lmp.so` but point to `libdeepmd_lmp.dylib` instead. ### Details The `libdeepmd_lmp` is a shared module. https://github.com/deepmodeling/deepmd-kit/blob/b875ea8f6661b6e1567537ead7e2b4a8b14ea113/source/lmp/plugin/CMakeLists.txt#L72 The build target name on macOS is `libdeepmd_lmp.so`. Because on macOS, the `CMAKE_SHARED_MODULE_SUFFIX` (`.so`) is different from `CMAKE_SHARED_LIBRARY_SUFFIX` (`.dynlib`). As a result, in previous versions, on macOS the symbolic link `dpplugin.so` was pointed to `libdeepmd_lmp.dylib`, which does not exist. One can check the conda-forge builds to confirm (e.g., [osx-arm64/deepmd-kit-2.2.9-cpu_py311hf5376d5_mpi_openmpi_0.conda](https://anaconda.org/conda-forge/deepmd-kit/2.2.9/download/osx-arm64/deepmd-kit-2.2.9-cpu_py311hf5376d5_mpi_openmpi_0.conda)). (cherry picked from commit abf3477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the broken symlink for
dpplugin.soon macOS. It should point tolibdeepmd_lmp.sobut point tolibdeepmd_lmp.dylibinstead.Details
The
libdeepmd_lmpis a shared module.deepmd-kit/source/lmp/plugin/CMakeLists.txt
Line 72 in b875ea8
The build target name on macOS is
libdeepmd_lmp.so.Because on macOS, the
CMAKE_SHARED_MODULE_SUFFIX(.so) is different fromCMAKE_SHARED_LIBRARY_SUFFIX(.dynlib). As a result, in previous versions, on macOS the symbolic linkdpplugin.sowas pointed tolibdeepmd_lmp.dylib, which does not exist. One can check the conda-forge builds to confirm (e.g., osx-arm64/deepmd-kit-2.2.9-cpu_py311hf5376d5_mpi_openmpi_0.conda).