Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tf): fix float32 for exclude_types in se_atten_v2 #3682

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 18, 2024

Fix type issue in previous PR #3651.

Fix type issue in previous PR deepmodeling#3651.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz added this to the v2.2.11 milestone Apr 18, 2024
@njzjz njzjz requested a review from wanghan-iapcm April 18, 2024 05:10
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (a04b46d) to head (005b5ed).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3682      +/-   ##
==========================================
- Coverage   81.89%   81.89%   -0.01%     
==========================================
  Files         508      508              
  Lines       46636    46636              
  Branches     2952     2952              
==========================================
- Hits        38192    38191       -1     
- Misses       7551     7552       +1     
  Partials      893      893              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Apr 18, 2024
Merged via the queue into deepmodeling:devel with commit cac8715 Apr 18, 2024
48 checks passed
@njzjz njzjz changed the title fix(tf): fix foat32 for exclude_types in se_atten_v2 fix(tf): fix float32 for exclude_types in se_atten_v2 Jun 4, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Jul 2, 2024
Fix type issue in previous PR deepmodeling#3651.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit cac8715)
@njzjz njzjz mentioned this pull request Jul 2, 2024
njzjz added a commit that referenced this pull request Jul 3, 2024
Fix type issue in previous PR #3651.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit cac8715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants