-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(test): split each pytest job into 6 separated jobs #3716
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughWalkthroughThe updates involve enhancing the Python testing workflow by configuring test jobs to run in parallel groups, caching test durations, and introducing a new job to combine these durations. Additionally, the test dependency Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files skipped from review due to trivial changes (2)
Additional comments not posted (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
.github/workflows/test_python.yml (1)
44-55
: The caching strategy for test durations is complex but well thought out, ensuring that durations do not get out of sync between groups. However, consider adding more comments to explain the rationale behind the specific key and restore-keys choices to aid future maintainability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3716 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 511 511
Lines 47363 47363
Branches 2952 2953 +1
=======================================
Hits 38898 38898
Misses 7572 7572
Partials 893 893 ☔ View full report in Codecov by Sentry. |
) Split each pytest job into 6 separated jobs in GHA. Currently, each separated job takes: - ~2.5 min for installation, which may need to be optimized in the future; - ~2 min for setup, which may be a defect and should be resolved in deepmodeling#3715; - 4~5 min for tests (expected). --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Split each pytest job into 6 separated jobs in GHA.
Currently, each separated job takes: