-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: remove multi-task support in tf #3763
Conversation
WalkthroughWalkthroughThe recent updates across the DeepMD library primarily involve the removal of the Changes
This table provides a concise overview of the key changes made in the library, emphasizing the removal of multi-task capabilities and adjustments in documentation to align with the new direction. Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Out of diff range and nitpick comments (7)
deepmd/tf/descriptor/se_r.py (5)
281-282
: The methodmerge_input_stats
lacks a detailed docstring. It's important for maintainability and understandability to have comprehensive documentation, especially for public or complex methods.
281-282
: The methodmerge_input_stats
lacks a detailed docstring. It's important for maintainability and understandability to have comprehensive documentation, especially for public or complex methods.
281-282
: The methodmerge_input_stats
lacks a detailed docstring. It's important for maintainability and understandability to have comprehensive documentation, especially for public or complex methods.
281-282
: The methodmerge_input_stats
lacks a detailed docstring. It's important for maintainability and understandability to have comprehensive documentation, especially for public or complex methods.
281-282
: The methodmerge_input_stats
lacks a detailed docstring. It's important for maintainability and understandability to have comprehensive documentation, especially for public or complex methods.deepmd/tf/descriptor/se_atten.py (1)
402-408
: Ensure that the statistical dictionary keys are correctly documented and used.While the keys in the statistical dictionary are standard, it's good practice to ensure they are documented somewhere in the method or class docstring for clarity, especially for large and complex methods like
compute_input_stats
.deepmd/utils/argcheck.py (1)
Line range hint
59-67
: Ensure that the deprecation warning includes more context about the deprecation, such as the version it was deprecated in and the alternative to use if applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3763 +/- ##
==========================================
+ Coverage 82.25% 82.26% +0.01%
==========================================
Files 513 511 -2
Lines 47666 46952 -714
Branches 2979 2980 +1
==========================================
- Hits 39207 38625 -582
+ Misses 7548 7416 -132
Partials 911 911 ☔ View full report in Codecov by Sentry. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Removed the `multi_task` parameter across various descriptor initialization methods, streamlining the setup process. - Introduced a new option `--head` for specifying a model branch to freeze in multi-task mode. - **Bug Fixes** - Corrected initialization and training processes by removing outdated multi-task functionalities. - **Documentation** - Updated guides on model freezing and training to reflect the removal of multi-task functionalities and the shift towards using the PyTorch backend. - **Refactor** - Eliminated redundant code and simplified parameter assignments in training scripts. - **Chores** - Removed unused dictionaries and outdated code across several modules to clean up the codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit
multi_task
parameter across various descriptor initialization methods, streamlining the setup process.--head
for specifying a model branch to freeze in multi-task mode.