Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PairTab Data #3812

Merged
merged 9 commits into from
May 23, 2024
Merged

Fix: PairTab Data #3812

merged 9 commits into from
May 23, 2024

Conversation

anyangml
Copy link
Collaborator

@anyangml anyangml commented May 23, 2024

one of the columns in the original table contains faulty data. I think this should resolve #3809

Summary by CodeRabbit

  • Bug Fixes
    • Improved weight computation in the atomic model to handle edge cases more effectively.
  • Tests
    • Updated the configuration related to a water potential calculation by modifying the value of "sw_rmax" in test_permutation.py.
    • Adjusted the precision used in tests by changing the places variable assignment in test_autodiff.py.

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Warning

Rate Limit Exceeded

@anyangml has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 28 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between bfbf6e2 and 7f7d55c.

Walkthrough

The recent changes focus on enhancing the _compute_weight function in the LinearAtomicModel class and adjusting a configuration value in test_permutation.py. These modifications aim to improve calculation accuracy and update potential calculation configurations for water systems.

Changes

File Path Change Summary
deepmd/pt/model/atomic_model/linear_atomic_model.py Updated _compute_weight function to use torch.where for conditional calculation of numerator.
source/tests/pt/model/test_permutation.py Modified "sw_rmax" value from 1.0 to 4.0 in the test configuration for water potential.
source/tests/pt/model/test_autodiff.py Updated places variable assignment from 8 to 6 in ForceTest and VirialTest classes.

Assessment against linked issues

Objective Addressed Explanation
Recent unit tests failures

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (f303484) to head (7f7d55c).
Report is 138 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3812      +/-   ##
==========================================
- Coverage   82.50%   81.25%   -1.25%     
==========================================
  Files         516      516              
  Lines       48938    48938              
  Branches     2981     2981              
==========================================
- Hits        40378    39767     -611     
- Misses       7649     8263     +614     
+ Partials      911      908       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml requested a review from njzjz May 23, 2024 06:51
@iProzd iProzd linked an issue May 23, 2024 that may be closed by this pull request
@iProzd iProzd removed a link to an issue May 23, 2024
@njzjz njzjz added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@anyangml anyangml requested a review from njzjz May 23, 2024 08:00
@njzjz njzjz enabled auto-merge May 23, 2024 09:07
@njzjz njzjz disabled auto-merge May 23, 2024 09:31
@anyangml anyangml enabled auto-merge May 23, 2024 09:37
@anyangml anyangml linked an issue May 23, 2024 that may be closed by this pull request
@anyangml anyangml added this pull request to the merge queue May 23, 2024
Merged via the queue into deepmodeling:devel with commit 591b94b May 23, 2024
60 checks passed
@anyangml anyangml deleted the fix/pairtab_data branch May 23, 2024 11:21
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
one of the columns in the original table contains faulty data. I think
this should resolve deepmodeling#3809

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved weight computation in the atomic model to handle edge cases
more effectively.
- **Tests**
- Updated the configuration related to a water potential calculation by
modifying the value of `"sw_rmax"` in `test_permutation.py`.
- Adjusted the precision used in tests by changing the `places` variable
assignment in `test_autodiff.py`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: anyangml <ap@aisi.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent unit tests failures
2 participants