fix(pt): build nlist faster with torch.amax

[iProzd]

Summary by CodeRabbit

• Performance Improvements
  • Enhanced the performance of coordinate extension in neighbor lists by optimizing internal computations.

[coderabbitai]

Walkthrough

Walkthrough

The extend_coord_with_ghosts function in nlist.py has been optimized by replacing torch.max with torch.amax. This change enhances performance by utilizing a more efficient function for computing the maximum values along a specified dimension.

Changes

File Path	Change Summary
deepmd/pt/utils/nlist.py	Replaced torch.max with torch.amax in the extend_coord_with_ghosts function for better performance.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3f6e511 and 510fe13.

Files selected for processing (1)

• deepmd/pt/utils/nlist.py (1 hunks)

Files skipped from review due to trivial changes (1)

• deepmd/pt/utils/nlist.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (3f6e511) to head (510fe13).
Report is 131 commits behind head on devel.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #3826   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files         513      513           
  Lines       48993    48993           
  Branches     2988     2986    -2     
=======================================
  Hits        40411    40411           
  Misses       7671     7671           
  Partials      911      911           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[njzjz]

I can observe 1% speed up in my computer.

[iProzd]

I can observe 1% speed up in my computer.

For dpa1 with atten_layer=0, it can speed up much more. See https://dptechnology.feishu.cn/wiki/JI8nwFJwDiqTMNkdgrFcwJ6Enmc