-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix DeepGlobalPolar and DeepWFC initlization #3834
fix: fix DeepGlobalPolar and DeepWFC initlization #3834
Conversation
Fix deepmodeling#3561. Fix deepmodeling#3562. Not sure if some one uses them, but it's good to keep compatibility. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughThe recent changes introduce mappings for "global_polar" and "wfc" in Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Tester
participant TempFile
participant DeepGlobalPolar
participant DeepWFC
Tester->>+TempFile: Create temporary model files
TempFile-->>Tester: Return file paths
Tester->>+DeepGlobalPolar: Instantiate with model file
Tester->>+DeepWFC: Instantiate with model file
DeepGlobalPolar-->>Tester: Return instance
DeepWFC-->>Tester: Return instance
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3834 +/- ##
==========================================
+ Coverage 82.53% 82.54% +0.01%
==========================================
Files 513 513
Lines 49040 49051 +11
Branches 2987 2985 -2
==========================================
+ Hits 40473 40489 +16
+ Misses 7656 7651 -5
Partials 911 911 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Fix deepmodeling#3561. Fix deepmodeling#3562. Not sure if some one uses them, but it's good to keep compatibility. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced support for "global_polar" and "wfc" mappings in evaluation backend. - Added `output_def` property to define model output for `DeepGlobalPolar` and `DeepWFC` classes. - **Bug Fixes** - Updated test setup to create temporary model files for `DeepGlobalPolar` and `DeepWFC`. - **Refactor** - `DeepGlobalPolar` and `DeepWFC` classes now inherit from `OldDeepTensor` for better structure and functionality. - **Tests** - Enhanced test coverage to include instantiation checks for `DeepGlobalPolar` and `DeepWFC` objects. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
Fix #3561. Fix #3562.
Not sure if some one uses them, but it's good to keep compatibility.
Summary by CodeRabbit
New Features
output_def
property to define model output forDeepGlobalPolar
andDeepWFC
classes.Bug Fixes
DeepGlobalPolar
andDeepWFC
.Refactor
DeepGlobalPolar
andDeepWFC
classes now inherit fromOldDeepTensor
for better structure and functionality.Tests
DeepGlobalPolar
andDeepWFC
objects.