Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump ase to 3.23.0 #3846

Merged
merged 1 commit into from
Jun 3, 2024
Merged

ci: bump ase to 3.23.0 #3846

merged 1 commit into from
Jun 3, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 31, 2024

Fix #3520.

Summary by CodeRabbit

  • Chores
    • Simplified the installation process by removing specific version references for the ase package in workflow files.
    • Updated the dependency version of "ase" to >=3.23.0 in pyproject.toml to ensure compatibility and resolve previous issues.

@njzjz njzjz requested a review from wanghan-iapcm May 31, 2024 22:31
@njzjz njzjz linked an issue May 31, 2024 that may be closed by this pull request
@njzjz njzjz added this to the v2.2.11 milestone May 31, 2024
Copy link
Contributor

coderabbitai bot commented May 31, 2024

Walkthrough

Walkthrough

The changes involve removing specific version references for the ase package in the .github/workflows/test_cc.yml and .github/workflows/test_cuda.yml files to simplify the installation process. Additionally, the pyproject.toml file is updated to set the dependency version of ase to >=3.23.0, addressing an issue resolved in that version.

Changes

Files Change Summary
.github/workflows/test_cc.yml Removed specific version reference for ase in the Python installation command.
.github/workflows/test_cuda.yml Removed specific version reference for ase in the pip install command.
pyproject.toml Updated ase dependency version to >=3.23.0 due to an issue resolved in that version.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Remove ase version when ase has new release (#3520)

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 42bf9f1 and 9aadf15.

Files selected for processing (3)
  • .github/workflows/test_cc.yml (1 hunks)
  • .github/workflows/test_cuda.yml (1 hunks)
  • pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/test_cc.yml
  • .github/workflows/test_cuda.yml
Additional comments not posted (1)
pyproject.toml (1)

74-74: Updated ASE version to >=3.23.0 aligns with the PR objectives to use the latest ASE version for testing and continuous integration.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@njzjz njzjz removed this from the v2.2.11 milestone May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.55%. Comparing base (42bf9f1) to head (9aadf15).
Report is 120 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3846      +/-   ##
==========================================
- Coverage   82.63%   82.55%   -0.08%     
==========================================
  Files         515      515              
  Lines       49533    49512      -21     
  Branches     2986     2977       -9     
==========================================
- Hits        40932    40876      -56     
+ Misses       7690     7671      -19     
- Partials      911      965      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jun 3, 2024
Merged via the queue into deepmodeling:devel with commit f23c77e Jun 3, 2024
60 checks passed
@njzjz njzjz added this to the v2.2.11 milestone Jul 2, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Jul 2, 2024
Fix deepmodeling#3520.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Chores**
- Simplified the installation process by removing specific version
references for the `ase` package in workflow files.
- Updated the dependency version of "ase" to `>=3.23.0` in
`pyproject.toml` to ensure compatibility and resolve previous issues.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit f23c77e)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this pull request Jul 2, 2024
njzjz added a commit that referenced this pull request Jul 3, 2024
Fix #3520.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Chores**
- Simplified the installation process by removing specific version
references for the `ase` package in workflow files.
- Updated the dependency version of "ase" to `>=3.23.0` in
`pyproject.toml` to ensure compatibility and resolve previous issues.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit f23c77e)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
Fix deepmodeling#3520.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Simplified the installation process by removing specific version
references for the `ase` package in workflow files.
- Updated the dependency version of "ase" to `>=3.23.0` in
`pyproject.toml` to ensure compatibility and resolve previous issues.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ase version when ase has new release
2 participants