-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): workaround to retry error decoding response body
from uv
#3889
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughThe recent updates standardize the installation process for dependencies like TensorFlow, Torch, and Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI/CD Pipeline
participant UV_with_retry.sh
participant Dependency Server
Developer->>CI/CD Pipeline: Triggers workflow
CI/CD Pipeline->>UV_with_retry.sh: Run install command
UV_with_retry.sh->>Dependency Server: Attempt to install dependency
Dependency Server-->>UV_with_retry.sh: Error response (if any)
UV_with_retry.sh->>UV_with_retry.sh: Retries up to 3 times on error
UV_with_retry.sh-->>CI/CD Pipeline: Returns success/failure
CI/CD Pipeline-->>Developer: Reports build/test result
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3889 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 518 518
Lines 50215 50215
Branches 2978 2982 +4
=======================================
Hits 41548 41548
Misses 7757 7757
Partials 910 910 ☔ View full report in Codecov by Sentry. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
…deepmodeling#3889) This PR uses a shell wrapper to check if the `error decoding response body` error message is in the uv stderr and retry if so. It is just a workaround for astral-sh/uv#2586 and astral-sh/uv#3514 and hope the upstream can fix it. Note that this PR does nothing with cibuildwheel. It's unclear how to retry with certain errors under its complex logic (feature requested in pypa/cibuildwheel#1846). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **Chores** - Standardized installation process for TensorFlow, Torch, and other dependencies across workflows by using `uv_with_retry.sh` script to ensure reliable installations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> (cherry picked from commit 359d19b) Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
…#3889) This PR uses a shell wrapper to check if the `error decoding response body` error message is in the uv stderr and retry if so. It is just a workaround for astral-sh/uv#2586 and astral-sh/uv#3514 and hope the upstream can fix it. Note that this PR does nothing with cibuildwheel. It's unclear how to retry with certain errors under its complex logic (feature requested in pypa/cibuildwheel#1846). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **Chores** - Standardized installation process for TensorFlow, Torch, and other dependencies across workflows by using `uv_with_retry.sh` script to ensure reliable installations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> (cherry picked from commit 359d19b) Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
…deepmodeling#3889) This PR uses a shell wrapper to check if the `error decoding response body` error message is in the uv stderr and retry if so. It is just a workaround for astral-sh/uv#2586 and astral-sh/uv#3514 and hope the upstream can fix it. Note that this PR does nothing with cibuildwheel. It's unclear how to retry with certain errors under its complex logic (feature requested in pypa/cibuildwheel#1846). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Standardized installation process for TensorFlow, Torch, and other dependencies across workflows by using `uv_with_retry.sh` script to ensure reliable installations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This PR uses a shell wrapper to check if the
error decoding response body
error message is in the uv stderr and retry if so. It is just a workaround for astral-sh/uv#2586 and astral-sh/uv#3514 and hope the upstream can fix it.Note that this PR does nothing with cibuildwheel. It's unclear how to retry with certain errors under its complex logic (feature requested in pypa/cibuildwheel#1846).
Summary by CodeRabbit
uv_with_retry.sh
script to ensure reliable installations.