Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): workaround to retry error decoding response body from uv #3889

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 19, 2024

This PR uses a shell wrapper to check if the error decoding response body error message is in the uv stderr and retry if so. It is just a workaround for astral-sh/uv#2586 and astral-sh/uv#3514 and hope the upstream can fix it.

Note that this PR does nothing with cibuildwheel. It's unclear how to retry with certain errors under its complex logic (feature requested in pypa/cibuildwheel#1846).

Summary by CodeRabbit

  • Chores
    • Standardized installation process for TensorFlow, Torch, and other dependencies across workflows by using uv_with_retry.sh script to ensure reliable installations.

njzjz added 2 commits June 19, 2024 19:33
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link
Contributor

coderabbitai bot commented Jun 19, 2024

Walkthrough

The recent updates standardize the installation process for dependencies like TensorFlow, Torch, and mpi4py across several GitHub workflow files. The key change involves replacing python -m uv pip install with a new script, uv_with_retry.sh, which includes a retry mechanism to handle installation errors more robustly. This ensures consistent and reliable installations during the build and testing phases for various configurations.

Changes

Files/Paths Change Summary
.github/workflows/build_cc.yml Updated installation commands to use source/install/uv_with_retry.sh for TensorFlow and other dependencies.
.github/workflows/test_cc.yml Standardized installation commands using source/install/uv_with_retry.sh.
.github/workflows/test_cuda.yml Modified installation commands to implement uv_with_retry.sh script for TensorFlow, Torch, and mpi4py.
.github/workflows/test_python.yml Revised installation process for mpich, torch, horovod, and mpi4py to utilize source/install/uv_with_retry.sh.
source/install/uv_with_retry.sh Introduced a script that retries the uv command up to 3 times on encountering the "error decoding response body" error.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CI/CD Pipeline
    participant UV_with_retry.sh
    participant Dependency Server

    Developer->>CI/CD Pipeline: Triggers workflow
    CI/CD Pipeline->>UV_with_retry.sh: Run install command
    UV_with_retry.sh->>Dependency Server: Attempt to install dependency
    Dependency Server-->>UV_with_retry.sh: Error response (if any)
    UV_with_retry.sh->>UV_with_retry.sh: Retries up to 3 times on error
    UV_with_retry.sh-->>CI/CD Pipeline: Returns success/failure
    CI/CD Pipeline-->>Developer: Reports build/test result
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

source/install/uv_with_retry.sh Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.74%. Comparing base (0c472d1) to head (facf45b).
Report is 118 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3889   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files         518      518           
  Lines       50215    50215           
  Branches     2978     2982    +4     
=======================================
  Hits        41548    41548           
  Misses       7757     7757           
  Partials      910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review June 20, 2024 00:54
@njzjz njzjz requested a review from wanghan-iapcm June 20, 2024 00:54
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jun 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2024
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jun 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2024
@njzjz njzjz added this pull request to the merge queue Jun 21, 2024
Merged via the queue into deepmodeling:devel with commit 359d19b Jun 21, 2024
60 checks passed
@njzjz njzjz deleted the retry-uv branch June 21, 2024 07:32
@njzjz njzjz added this to the v2.2.11 milestone Jul 2, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Jul 2, 2024
…deepmodeling#3889)

This PR uses a shell wrapper to check if the `error decoding response
body` error message is in the uv stderr and retry if so. It is just a
workaround for astral-sh/uv#2586 and
astral-sh/uv#3514 and hope the upstream can
fix it.

Note that this PR does nothing with cibuildwheel. It's unclear how to
retry with certain errors under its complex logic (feature requested in
pypa/cibuildwheel#1846).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Chores**
- Standardized installation process for TensorFlow, Torch, and other
dependencies across workflows by using `uv_with_retry.sh` script to
ensure reliable installations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
(cherry picked from commit 359d19b)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this pull request Jul 2, 2024
njzjz added a commit that referenced this pull request Jul 3, 2024
…#3889)

This PR uses a shell wrapper to check if the `error decoding response
body` error message is in the uv stderr and retry if so. It is just a
workaround for astral-sh/uv#2586 and
astral-sh/uv#3514 and hope the upstream can
fix it.

Note that this PR does nothing with cibuildwheel. It's unclear how to
retry with certain errors under its complex logic (feature requested in
pypa/cibuildwheel#1846).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Chores**
- Standardized installation process for TensorFlow, Torch, and other
dependencies across workflows by using `uv_with_retry.sh` script to
ensure reliable installations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
(cherry picked from commit 359d19b)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
…deepmodeling#3889)

This PR uses a shell wrapper to check if the `error decoding response
body` error message is in the uv stderr and retry if so. It is just a
workaround for astral-sh/uv#2586 and
astral-sh/uv#3514 and hope the upstream can
fix it.

Note that this PR does nothing with cibuildwheel. It's unclear how to
retry with certain errors under its complex logic (feature requested in
pypa/cibuildwheel#1846).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Standardized installation process for TensorFlow, Torch, and other
dependencies across workflows by using `uv_with_retry.sh` script to
ensure reliable installations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants