pt: fix compile error when use intel mpi #3919

CaRoLZhangxy · 2024-06-27T07:46:15Z

MPIX_Query_cuda_support() is not defined in intelMPI

Summary by CodeRabbit

New Features
- Introduced conditional handling for CUDA awareness based on the MPI version to improve compatibility and performance for CUDA-enabled environments.

coderabbitai · 2024-06-27T07:46:21Z

Walkthrough

In the latest update, checks for CUDA support within MPI were integrated into the build system and source code. Conditional logic was added to manage CUDA awareness based on whether MPIX_Query_cuda_support is available. If unavailable, NO_CUDA_AWARE is defined, altering configuration and functionality accordingly. This adjustment ensures compatibility and efficient handling of MPI versions with and without CUDA support.

Changes

File	Summary
`source/op/pt/CMakeLists.txt`	Added a check for `MPIX_Query_cuda_support` using `CheckCXXSymbolExists` and defined `NO_CUDA_AWARE` if absent. Updated linking and compilation definitions for `deepmd_op_pt`.
`source/op/pt/comm.cc`	Added conditional logic related to CUDA support based on MPI version. Introduced preprocessor directives (`NO_CUDA_AWARE`, `I_MPI_VERSION`, `MPIX_Query_cuda_support`) and adjusted the `Border` class accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant CMakeLists.txt
    participant Compilation
    participant comm.cc
    participant MPI
    participant Execution
    
    CMakeLists.txt->>+Compilation: Check for MPIX_Query_cuda_support
    Compilation-->>CMakeLists.txt: Define NO_CUDA_AWARE if absent
    comm.cc-->>comm.cc: Conditional compilation (NO_CUDA_AWARE)
    MPI-->>comm.cc: Provide MPI version and CUDA support
    Execution->>comm.cc: Instantiate Border class
    comm.cc-->>Execution: Adjust behavior based on CUDA awareness

Tip

Early access features: enabled

We are currently testing the following features in early access:

OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
Please join our Discord Community to provide feedback and report issues.
OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

source/op/pt/comm.cc (1)

Line range hint 204-345: Consistency check and optimization suggestion for backward method.

The implementation is consistent with the forward method and correctly handles MPI and CUDA logic. Consider optimizing memory usage and data transfers, especially when CUDA is not aware, to improve performance.

source/op/pt/comm.cc

codecov · 2024-06-27T08:05:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (e809e64) to head (98c9937).
Report is 112 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #3919      +/-   ##
==========================================
- Coverage   82.88%   82.87%   -0.01%     
==========================================
  Files         520      520              
  Lines       50678    50678              
  Branches     3018     3011       -7     
==========================================
- Hits        42003    42000       -3     
- Misses       7738     7740       +2     
- Partials      937      938       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

njzjz · 2024-06-27T09:03:51Z

I can find MPIX_Query_cuda_support in mpi.h, so I don't know what you mean.

grep MPIX_Query_cuda_support ~/intel/oneapi/mpi/2021.13/include/mpi.h
int MPIX_Query_cuda_support(void) MPICH_API_PUBLIC;
int PMPIX_Query_cuda_support(void) MPICH_API_PUBLIC;

CaRoLZhangxy · 2024-06-28T04:21:42Z

grep MPIX_Query_cuda_support ~/intel/oneapi/mpi/2021.13/include/mpi.h

My intel MPI version is 2021.5.1 and there is no definition for MPIX_Query_cuda_support. What's more, it seems that there is no official api document for intel MPI.

njzjz · 2024-06-28T04:25:20Z

My intel MPI version is 2021.5.1 and there is no definition for MPIX_Query_cuda_support.

Perhaps use CMake's CheckSymbolExists. It seems very hard to check whether this function exists according to other flags.

source/op/pt/CMakeLists.txt

source/op/pt/comm.cc

for more information, see https://pre-commit.ci

source/op/pt/CMakeLists.txt

`MPIX_Query_cuda_support()` is not defined in intelMPI  ## Summary by CodeRabbit - **New Features** - Introduced conditional handling for CUDA awareness based on the MPI version to improve compatibility and performance for CUDA-enabled environments.  --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

fix compile error when use intel mpi

ec0d920

coderabbitai bot reviewed Jun 27, 2024

View reviewed changes

source/op/pt/comm.cc Outdated Show resolved Hide resolved

github-actions bot added the OP label Jun 27, 2024

CaRoLZhangxy requested a review from njzjz June 27, 2024 08:09

use cmake instead

9cc67a7

njzjz requested changes Jun 28, 2024

View reviewed changes

source/op/pt/CMakeLists.txt Show resolved Hide resolved

source/op/pt/CMakeLists.txt Show resolved Hide resolved

source/op/pt/comm.cc Outdated Show resolved Hide resolved

CaRoLZhangxy and others added 4 commits July 1, 2024 04:25

modify include path(still not found)

b8cce46

[pre-commit.ci] auto fixes from pre-commit.com hooks

504bd29

for more information, see https://pre-commit.ci

add include and lib

4e30cd4

add ompi

91e601f

CaRoLZhangxy requested a review from njzjz July 1, 2024 07:39

[pre-commit.ci] auto fixes from pre-commit.com hooks

78cfa56

for more information, see https://pre-commit.ci

njzjz reviewed Jul 1, 2024

View reviewed changes

source/op/pt/CMakeLists.txt Outdated Show resolved Hide resolved

fix mpi include and lib

b63bf65

CaRoLZhangxy requested a review from njzjz July 2, 2024 04:58

CaRoLZhangxy and others added 2 commits July 2, 2024 06:05

fix compile error

214ed8f

Merge branch 'devel' into fix-intelmpi

98c9937

njzjz approved these changes Jul 2, 2024

View reviewed changes

njzjz enabled auto-merge July 2, 2024 17:08

njzjz added this pull request to the merge queue Jul 2, 2024

Merged via the queue into deepmodeling:devel with commit 6092737 Jul 2, 2024
60 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pt: fix compile error when use intel mpi #3919

pt: fix compile error when use intel mpi #3919

CaRoLZhangxy commented Jun 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

codecov bot commented Jun 27, 2024 •

edited

Loading

njzjz commented Jun 27, 2024

CaRoLZhangxy commented Jun 28, 2024

njzjz commented Jun 28, 2024 •

edited

Loading

pt: fix compile error when use intel mpi #3919

pt: fix compile error when use intel mpi #3919

Conversation

CaRoLZhangxy commented Jun 27, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jun 27, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 27, 2024 • edited Loading

Codecov Report

njzjz commented Jun 27, 2024

CaRoLZhangxy commented Jun 28, 2024

njzjz commented Jun 28, 2024 • edited Loading

CaRoLZhangxy commented Jun 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 27, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Jun 27, 2024 •

edited

Loading

njzjz commented Jun 28, 2024 •

edited

Loading