fix(pt): do not overwrite disp_file when restarting training #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughWalkthroughThe recent changes to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TrainingScript as training.py
participant FileSystem
User->>TrainingScript: Start training
alt restart_training is true
TrainingScript->>FileSystem: Open file in append mode
else restart_training is false
TrainingScript->>FileSystem: Open file in write mode
end
alt SAMPLER_RECORD is true
TrainingScript->>FileSystem: Create file for recording
end
TrainingScript->>User: Training process starts
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
for more information, see https://pre-commit.ci
iProzd
approved these changes
Jul 16, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+633
to
+637
| open( | ||
| self.disp_file, | ||
| mode="w" if not self.restart_training else "a", | ||
| buffering=1, | ||
| ) |
Check warning
Code scanning / CodeQL
File is not always closed Warning
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
wanghan-iapcm
approved these changes
Jul 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3985 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 522 522
Lines 50872 50872
Branches 3015 3015
=======================================
Hits 42142 42142
Misses 7795 7795
Partials 935 935 ☔ View full report in Codecov by Sentry. |
Merged
via the queue into
deepmodeling:devel
with commit Jul 16, 2024
782f1e2
59 of 60 checks passed
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this pull request
Sep 18, 2024
…eling#3985) New contents should be appended when restarting <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved training process by conditionally appending to files based on the `restart_training` flag. - Added functionality to create a record file when `SAMPLER_RECORD` is true. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New contents should be appended when restarting
Summary by CodeRabbit
restart_trainingflag.SAMPLER_RECORDis true.