-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix PT AutoBatchSize OOM bug and merge execute_all into base #4047
Conversation
Fix deepmodeling#4036. Fix deepmodeling#4037. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughWalkthroughThe changes primarily involve the removal of the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (1)
deepmd/utils/batch_size.py (1)
159-160
: Add a brief note about Array API compatibility.To improve clarity, add a brief note in the docstring about the Array API compatibility.
+ This method is compatible with Array API, allowing it to handle various array-like objects.
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #4047 +/- ##
==========================================
- Coverage 82.95% 82.94% -0.02%
==========================================
Files 522 522
Lines 51039 51020 -19
Branches 3028 3028
==========================================
- Hits 42338 42317 -21
- Misses 7756 7757 +1
- Partials 945 946 +1 ☔ View full report in Codecov by Sentry. |
…epmodeling#4047) Fix deepmodeling#4036. Fix deepmodeling#4037. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved batch processing methods to enhance compatibility with various array-like objects through Array API integration. - Added a new test suite to validate the functionality of the `AutoBatchSize` class under different conditions, ensuring robust behavior with GPU resources. - **Bug Fixes** - Removed the outdated `execute_all` method, streamlining batch execution processes. - **Documentation** - Updated minimum TensorFlow version requirement to 2.7 for backend compatibility. - Clarified installation instructions to reflect the updated TensorFlow version requirement. - **Chores** - Specified minimum NumPy version dependency as 1.21 in project configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fix #4036. Fix #4037.
Summary by CodeRabbit
New Features
AutoBatchSize
class under different conditions, ensuring robust behavior with GPU resources.Bug Fixes
execute_all
method, streamlining batch execution processes.Documentation
Chores