Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace datetime.datetime.utcnow which is deprecated #4067

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 20, 2024

Fix #4063.

Summary by CodeRabbit

  • Improvements
    • Enhanced the accuracy and clarity of time representation in the model saving feature.
    • Updated copyright year retrieval to ensure timezone awareness for improved precision.
    • Expanded linting capabilities by adding datetime-related checks, which can improve code quality.

@njzjz njzjz linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

Walkthrough

Walkthrough

The recent changes enhance UTC time handling in the save_dp_model function by replacing the deprecated datetime.utcnow() with datetime.datetime.now(tz=datetime.timezone.utc), ensuring better timezone clarity. Additionally, the pyproject.toml file now includes a new entry, "DTZ", to improve linting capabilities for datetime usage. These updates aim to bolster code quality and adherence to best practices.

Changes

Files Change Summary
deepmd/dpmodel/utils/serialization.py, doc/conf.py Updated time retrieval to use timezone-aware UTC time in both serialization and copyright declarations.
pyproject.toml Added "DTZ" to select list for improved datetime linting checks.

Assessment against linked issues

Objective Addressed Explanation
Deprecation of datetime.datetime.utcnow() (#[4063])

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the Docs label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (d77c075) to head (d0ba537).
Report is 173 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #4067   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files         522      522           
  Lines       51044    51045    +1     
  Branches     3031     3028    -3     
=======================================
+ Hits        42341    42342    +1     
+ Misses       7759     7757    -2     
- Partials      944      946    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Aug 21, 2024
Merged via the queue into deepmodeling:devel with commit 8abb523 Aug 21, 2024
60 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
…ling#4067)

Fix deepmodeling#4063.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Improvements**
- Enhanced the accuracy and clarity of time representation in the model
saving feature.
- Updated copyright year retrieval to ensure timezone awareness for
improved precision.
- Expanded linting capabilities by adding datetime-related checks, which
can improve code quality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: datetime.datetime.utcnow() is deprecated
2 participants