fix(pt): make state_dict safe for weights_only

[iProzd]

See #4147 and #4143.
We can first make state_dict safe for weights_only, then make a breaking change when loading state_dict in the future.

Summary by CodeRabbit

• New Features

  • Enhanced model saving functionality by ensuring learning rates are consistently stored as floats, improving type consistency.

• Bug Fixes

  • Updated model loading behavior in tests to focus solely on model weights, which may resolve issues related to state dictionary loading.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve modifications to the save_model method in the training.py file to ensure that learning rates are explicitly converted to floats before storage. Additionally, the torch.load function calls in three test methods of the test_change_bias.py file have been updated to include the weights_only=True argument, changing the behavior to load only the model weights instead of the entire state dictionary.

Changes

File	Change Summary
deepmd/pt/train/training.py	Modified save_model method to convert learning rates to floats before storing and changed how optimizer state is saved.
source/tests/pt/test_change_bias.py	Updated torch.load calls in three test methods to include weights_only=True, focusing on loading model weights only.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ModelTrainer
    participant Optimizer
    participant Torch

    User->>ModelTrainer: save_model(save_path, lr, step)
    ModelTrainer->>Optimizer: get state_dict()
    Optimizer->>ModelTrainer: return state_dict
    ModelTrainer->>ModelTrainer: convert lr to float
    ModelTrainer->>Torch: save model with state_dict

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 85c4f3a and 5691ed8.

Files selected for processing (1)

• deepmd/pt/train/training.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• deepmd/pt/train/training.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (c084b20) to head (5691ed8).
Report is 189 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4148      +/-   ##
==========================================
- Coverage   83.37%   83.37%   -0.01%     
==========================================
  Files         532      532              
  Lines       52166    52169       +3     
  Branches     3046     3046              
==========================================
+ Hits        43493    43494       +1     
- Misses       7726     7727       +1     
- Partials      947      948       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.