-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump tensorflow/build image to 2.18 #4252
ci: bump tensorflow/build image to 2.18 #4252
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
📝 WalkthroughWalkthroughThe pull request updates the workflow configuration for building a C library by changing the TensorFlow build version from "2.15" to "2.18" in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/package_c.yml (1)
21-24
: Consider documenting version matrix strategy.The matrix maintains two different builds:
- Latest TensorFlow (2.18) without version constraints
- CUDA 11 build (2.14) with specific version constraints
Consider adding comments to explain why two different versions are maintained and what each build is used for.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/package_c.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/package_c.yml (1)
21-24
: LGTM! Please verify TensorFlow compatibility.The version bump from 2.15 to 2.18 looks good, but since there's no version constraint specified for 2.18, we should ensure compatibility with dependent packages.
Let's verify if there are any version constraints in the repository:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4252 +/- ##
==========================================
+ Coverage 84.22% 84.23% +0.01%
==========================================
Files 547 548 +1
Lines 51334 51425 +91
Branches 3051 3051
==========================================
+ Hits 43235 43317 +82
- Misses 7147 7150 +3
- Partials 952 958 +6 ☔ View full report in Codecov by Sentry. |
Fix the CI error. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated TensorFlow build version from 2.15 to 2.18 in the C library build workflow. This change ensures compatibility with the latest TensorFlow features and improvements during the library's build process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> (cherry picked from commit a66afd3)
Fix the CI error. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated TensorFlow build version from 2.15 to 2.18 in the C library build workflow. This change ensures compatibility with the latest TensorFlow features and improvements during the library's build process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> (cherry picked from commit a66afd3)
Fix the CI error.
Summary by CodeRabbit
This change ensures compatibility with the latest TensorFlow features and improvements during the library's build process.