Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: raise clear error when broken symbolic link is found #366

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 21, 2023

One currently gets a RecursionError when a broken symbolic link is uploaded, as it tries to walk again and again.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (cc08915) 57.75% compared to head (c9bb297) 57.69%.

❗ Current head c9bb297 differs from pull request most recent head 650d6cc. Consider uploading reports for the commit 650d6cc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   57.75%   57.69%   -0.07%     
==========================================
  Files          30       30              
  Lines        3371     3373       +2     
==========================================
- Hits         1947     1946       -1     
- Misses       1424     1427       +3     
Files Changed Coverage Δ
dpdispatcher/ssh_context.py 80.80% <0.00%> (-0.39%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz merged commit dd2b191 into deepmodeling:master Sep 22, 2023
24 checks passed
@njzjz njzjz deleted the ignore-bad-symlink branch September 22, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant