Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove association between ABACUS/STRU and the element number in param.json #1076

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

pxlxingliang
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.71%. Comparing base (c1937ae) to head (4ae4dc6).
Report is 202 commits behind head on devel.

Files Patch % Lines
dpgen/generator/lib/abacus_scf.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1076      +/-   ##
==========================================
+ Coverage   39.49%   39.71%   +0.22%     
==========================================
  Files          99       99              
  Lines       17998    18002       +4     
==========================================
+ Hits         7108     7150      +42     
+ Misses      10890    10852      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit e3f98e0 into deepmodeling:devel Dec 18, 2022
@pxlxingliang pxlxingliang deleted the stru branch January 28, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants