Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove old dispatcher #1097

Merged
merged 4 commits into from
Dec 31, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Dec 30, 2022

Remove the old dispatcher and all related tests and examples.
Fix #1002. Close #522.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz linked an issue Dec 30, 2022 that may be closed by this pull request
3 tasks
@njzjz njzjz marked this pull request as ready for review December 30, 2022 08:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Base: 39.55% // Head: 46.06% // Increases project coverage by +6.51% 🎉

Coverage data is based on head (003cd2a) compared to base (ed26994).
Patch coverage: 20.68% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1097      +/-   ##
==========================================
+ Coverage   39.55%   46.06%   +6.51%     
==========================================
  Files          99       82      -17     
  Lines       17981    14452    -3529     
==========================================
- Hits         7112     6658     -454     
+ Misses      10869     7794    -3075     
Impacted Files Coverage Δ
dpgen/auto_test/common_equi.py 63.75% <0.00%> (+0.60%) ⬆️
dpgen/auto_test/common_prop.py 38.81% <0.00%> (+0.10%) ⬆️
dpgen/remote/decide_machine.py 87.50% <ø> (-4.50%) ⬇️
dpgen/simplify/simplify.py 0.00% <0.00%> (ø)
dpgen/data/gen.py 51.75% <11.11%> (+0.35%) ⬆️
dpgen/generator/lib/run_calypso.py 10.24% <25.00%> (+0.21%) ⬆️
dpgen/generator/run.py 65.20% <28.57%> (+0.14%) ⬆️
dpgen/dispatcher/Dispatcher.py 84.21% <50.00%> (+43.66%) ⬆️
dpgen/arginfo.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AnguseZhang AnguseZhang merged commit 749e28a into deepmodeling:devel Dec 31, 2022
@njzjz njzjz deleted the remove-old-dispatcher branch January 1, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove old dispatcher
5 participants