fix for node 18, closes #84

deepnest-io · May 17, 2023 · 18aa166 · 18aa166
1 parent 6f72856
commit 18aa166
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -16,8 +16,7 @@ jobs:
 
     strategy:
       matrix:
-                            # enable further versions if supported/needed
-        node-version: [12.x, 14.x] #, 16.x, 18.x]
+        node-version: [12.x, 14.x, 16.x, 18.x]
 
     steps:
     - uses: actions/checkout@v3

diff --git a/README.md b/README.md
@@ -30,7 +30,7 @@ issues.
 
 ## Prerequisites
 
-- **Node 12/14:** Use [Node.js](https://nodejs.org) version 12, 14. You can use the Node Version Manager (nvm):
+- **Node 12/14/16/18:** [Node.js](https://nodejs.org). You can use the Node Version Manager (nvm):
   -  [nvm-windows](https://github.com/coreybutler/nvm-windows/releases) to download Node and change versions.
 - **Python 3.7.9** You can use the Python Version Manager (pyenv):
   - [pyenv-win](https://github.com/pyenv-win/pyenv-win) to download and change versions.

diff --git a/binding.gyp b/binding.gyp
@@ -1,4 +1,7 @@
 {
+  'variables' : {
+    'openssl_fips': '',
+  },
   "targets": [
     {
       "target_name": "addon",