Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fedora] Build fails Xcopy command not found #107

Closed
bosd opened this issue Aug 15, 2023 · 5 comments
Closed

[Fedora] Build fails Xcopy command not found #107

bosd opened this issue Aug 15, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@bosd
Copy link
Contributor

bosd commented Aug 15, 2023

Describe the bug
Unable to build on Fedora Linux. Xcopy command not found.
The xcopy command is windows specific.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the Repo
  2. cd Deepnest
  3. sudo dnf groupinstall "Development Tools" "Development Libraries"
  4. sudo dnf install make automake gcc gcc-c++ kernel-devel
  5. npm install
  6. npm run build

Expected behavior
Deepnest is able to build. (I know other platforms then windows are not yet supported)

Screenshots


[bosd@fedora Deepnest]$ npm run build

> deepnest@1.1.4 build
> mkdir minkowski >nul 2>&1|echo .>nul && mkdir minkowski/Release >nul 2>&1|echo .>nul && ./node_modules/.bin/electron-rebuild && npm run copy

✔ Rebuild Complete

> deepnest@1.1.4 copy
> xcopy /s /y .\build\Release .\minkowski\Release

sh: line 1: xcopy: command not found

Desktop (please complete the following information):

  • OS: Fedora 38
  • Deepnest 1.1.4
  • npm 8.19.2

Additional context
Propably better to use some form of platform independent copy method.

@bosd bosd added the bug Something isn't working label Aug 15, 2023
@bosd
Copy link
Contributor Author

bosd commented Aug 15, 2023

xcopy seems Windows dependent.
CP seems Unix dependent.

Maybe it is possible to implement fs.copy.
To be platform independent.
source: https://stackoverflow.com/a/76375643
and https://bobbyhadz.com/blog/copy-folder-recursively-in-node-js

@bosd bosd changed the title [Fedora] Build fails Xcopy [Fedora] Build fails Xcopy command not found Aug 15, 2023
@tisaconundrum2
Copy link

tisaconundrum2 commented Aug 15, 2023

yes, this is correct. xcopy is a windows based command. If you're using .ps1, .bat, .cmd file, know that that is a dedicated Windows script.

@ghost
Copy link

ghost commented Aug 22, 2023

Unable to build on Fedora Linux.

@bosd The build is currently only validated on Windows.

@bosd
Copy link
Contributor Author

bosd commented Aug 23, 2023

Maybe not the highest priority to make the build script platform independent.
I've had succes building it on linux (fedora 38) with my the linux version of the script in my fork.
https://github.com/bosd/Deepnest/tree/path

@ghost ghost added this to the LinuxBuild milestone Aug 23, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

Maybe not the highest priority to make the build script platform independent.

It is highly important that you do not "break" the development flow, we need to focus on this here:

As for solving the xcopy issue, it is trivial, e.g. via this:

https://stackoverflow.com/a/59823713/21521485

(but no one should work on the electron 6 version, when a electron 12 version is available)

@ghost ghost closed this as completed in ad496ed Aug 25, 2023
@ghost ghost reopened this Aug 25, 2023
ghost pushed a commit that referenced this issue Aug 25, 2023
ghost pushed a commit that referenced this issue Aug 25, 2023
@ghost ghost closed this as completed in b19de4c Aug 25, 2023
ghost pushed a commit that referenced this issue Aug 26, 2023
ghost pushed a commit that referenced this issue Sep 10, 2023
ghost pushed a commit that referenced this issue Sep 26, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants