Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for node 18, closes #84 #85

Merged
1 commit merged into from May 17, 2023
Merged

fix for node 18, closes #84 #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ jobs:

strategy:
matrix:
# enable further versions if supported/needed
node-version: [12.x, 14.x] #, 16.x, 18.x]
node-version: [12.x, 14.x, 16.x, 18.x]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ issues.

## Prerequisites

- **Node 12/14:** Use [Node.js](https://nodejs.org) version 12, 14. You can use the Node Version Manager (nvm):
- **Node 12/14/16/18:** [Node.js](https://nodejs.org). You can use the Node Version Manager (nvm):
- [nvm-windows](https://github.com/coreybutler/nvm-windows/releases) to download Node and change versions.
- **Python 3.7.9** You can use the Python Version Manager (pyenv):
- [pyenv-win](https://github.com/pyenv-win/pyenv-win) to download and change versions.
Expand Down
3 changes: 3 additions & 0 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
'variables' : {
'openssl_fips': '',
},
"targets": [
{
"target_name": "addon",
Expand Down