Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed download_file #121

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: removed download_file #121

merged 1 commit into from
Nov 26, 2024

Conversation

sg-s
Copy link
Collaborator

@sg-s sg-s commented Nov 25, 2024

changes

  • removed download_file
  • refactored rest of code to use download_files

@sg-s sg-s requested a review from a team as a code owner November 25, 2024 19:42
@sg-s sg-s self-assigned this Nov 25, 2024
@sg-s sg-s enabled auto-merge (squash) November 25, 2024 19:43
kennyjwilli
kennyjwilli approved these changes Nov 25, 2024
View reviewed changes
tests/fixtures/responses/describe_database_stats.json Show resolved Hide resolved
src/data_hub/api.py Show resolved Hide resolved
@sg-s sg-s merged commit e79b204 into main Nov 26, 2024
12 checks passed
@sg-s sg-s deleted the download-refactor branch November 26, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyjwilli kennyjwilli kennyjwilli approved these changes

Assignees

@sg-s sg-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sg-s @kennyjwilli