Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update custom_el #481

Merged

Conversation

Ramimashkouk
Copy link
Member

These are the dream_kg distripution updates that corresponds to custom-entity-linking

any([prev_uttr.startswith(q_word) for q_word in ["what ", "who ", "when ", "where "]])
or "?" in prev_uttr
)
if is_q and len(cur_uttr.split())<3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а что тут проверяется и почему так?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну то есть я понимаю, что вы смотрите количество слов, но почему контекст нужен только для коротких реплик?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в случае если пред. реплика бота была вопросом и юзер ответил односложно, учитывается контекст тк в ответе "yes/no/okay" нет никакой информации. В дуригх случаях контекст не особо нужен

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поняла!

if "relation" in triplet:
rel = triplet["relation"]
elif "property" in triplet:
rel = triplet["property"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может else: rel = "" для красоты?

Copy link
Contributor

@Kpetyxova Kpetyxova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Рами, добавь, пожалуйста, сразу карточки контейнера для custom-entity-linking:
• в dream/annotators/custom_entity_linking/service_configs/custom_entity_linking/ два файла: environment.yml and service.yml, которые описывают докер-контейнеры
• в dream/components/
А также порт в dream/components.tsv, и поправь source у custom-entity-linking в assistant_dists/dream_kg/pipeline_conf.json

@Ramimashkouk Ramimashkouk merged commit 313b497 into feat/custom_entity_linking Jun 2, 2023
@Ramimashkouk Ramimashkouk deleted the feat/new_custom_entity_linking branch June 5, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants