Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request template #22

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Pull Request template #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
## Pull Request template

Open the PR as a **draft**, and go through the self-review checklist before marking it as **ready for review**.

**Checklist before requesting a review:**

- [ ] My solution follows the software design principles: DRY, YAGNI, KISS, PoLA, and SOLID (unless a major refactoring would be required).
- [ ] I have not mixed refactoring changes with functionality changes (these should made in another PR that can be conducted in parallel but merged first).
- [ ] I have commented on my code in non-obvious areas.
- [ ] When adding or renaming environment variables, I have updated all relevant places.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have outlined all the changes in the PR comment.
- [ ] The PR title describes the changes accurately.
- [ ] (optional) The PR title starts with related user story / issue number.

⚠️ Before requesting a review, delete the above checklist, leaving only the list of changes made.
Loading