Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable multiprocessing in Inferencer(#117) #128

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Add option to disable multiprocessing in Inferencer(#117) #128

merged 1 commit into from
Oct 25, 2019

Conversation

tanaysoni
Copy link
Contributor

The time incurred in spawning processes could outweigh performance boost for very small number of dicts, eg, HTTP APIs for inference. A new param use_multiprocessing allows to disable multiprocessing for such use cases.

@tanaysoni tanaysoni requested a review from tholor October 25, 2019 11:01
tholor
tholor approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good! We can do the renaming also later ...

@tanaysoni tanaysoni merged commit 7f2203e into master Oct 25, 2019
@tanaysoni tanaysoni deleted the add_use_multiprocess_flag_inferencer branch October 25, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanaysoni @tholor