Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change context in QA formatted preds to not split words #138

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Change context in QA formatted preds to not split words #138

merged 1 commit into from
Nov 11, 2019

Conversation

Timoeller
Copy link
Contributor

Additionally:
Bugfix checking for validity,
Add max ans len param

@Timoeller Timoeller requested a review from tholor November 8, 2019 17:05
@Timoeller Timoeller self-assigned this Nov 8, 2019
tholor
tholor approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tholor tholor added enhancement New feature or request part: inference Inferencer task: QA Question Answering labels Nov 11, 2019
@Timoeller Timoeller merged commit fb6370a into master Nov 11, 2019
@Timoeller Timoeller deleted the qa_context_words branch January 3, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees

@Timoeller Timoeller

Labels
enhancement New feature or request part: inference Inferencer task: QA Question Answering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Timoeller @tholor