Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inferencer for better multiprocessing with QA / haystack #278

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Improve inferencer for better multiprocessing with QA / haystack #278

merged 3 commits into from
Mar 13, 2020

Conversation

tholor
Copy link
Member

@tholor tholor commented Mar 13, 2020

  • Adding arg to disable tqdm (is very messy with multiprocessing)
  • Adding arg to set doc_stride for QA when loading an inferencer
  • Replacing ExitStack() block with pool.close() / pool.join() as it caused trouble with fastAPI / uvicorn deployments
  • Doing one matrix operation for QA aggregation directly on GPU

@tholor tholor requested a review from tanaysoni March 13, 2020 14:20
@tholor tholor merged commit 776554e into master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanaysoni tanaysoni tanaysoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tholor @tanaysoni