Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional s3 auth via params #511

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Add optional s3 auth via params #511

merged 1 commit into from
Sep 2, 2020

Conversation

tholor
Copy link
Member

@tholor tholor commented Sep 2, 2020

Adding another option to do authentication in download_from_s3()

The default and recommended authentication follows boto3's trajectory of checking for ENV variables, .aws/credentials etc. (see https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html).

With this PR, there's also the option to pass access_key, secret_access_key and region_name directly as this is needed in some enterprise environments with local s3 deployments.

@tholor tholor requested a review from tanaysoni September 2, 2020 09:51
@tholor tholor merged commit dc4af09 into master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants