-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dense Passage Retriever (incl. Training) #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first draft for the processor. Let's iterate on it as there are quite some design decisions to be discussed.
…to dpr_processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left a few comment for smaller changes.
Plus there's one bigger topic left: refactoring the conversion of DPR from/to transformers to the new FARM style introduced in #576 (see my comment). However, I think we can tackle that one better in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Looking good!
Provide functionality for Dense Passage Retrieval training
TO_DO:
Tokenization
DPRContextEncoderTokenizer
andDPRQuestionEncoderTokenizer
DPRProcessor:
with
embed_title = False
with
embed_title=True
_sample_to_features
file_to_dict: reads json in DPR format and returns list of dictionaries
-Usage:
using fast tokenizer: