Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate model on best model when doing early stopping #524

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Evaluate model on best model when doing early stopping #524

merged 3 commits into from
Sep 7, 2020

Conversation

PhilipMay
Copy link
Contributor

Fix for #522

@PhilipMay PhilipMay mentioned this pull request Sep 6, 2020
Closed
@Timoeller Timoeller self-requested a review September 7, 2020 07:56
Timoeller
Timoeller approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@Timoeller Timoeller merged commit a8a70a0 into deepset-ai:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilipMay @Timoeller