New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed conversion of BertForMaskedLM to transformers #555

Merged

Timoeller merged 1 commit into deepset-ai:master from himanshurawlani:fix_BertForMaskedLM_conversion_transformers

Sep 24, 2020

Contributor

himanshurawlani commented Sep 23, 2020

Fix for issue #533

Made the following changes:

Added layer_dims attribute in FARM's BertLMHead class as described in the issue.
Added check for the conversion of AdaptiveModel with 2 prediction heads (where the first prediction head is "language_modelling") in AdaptiveModel.convert_to_transformers()


          Fixed conversion of BertForMaskedLM to transformers

2812a50

Timoeller approved these changes

View reviewed changes

Contributor

Timoeller left a comment

Looking good, thanks for this simple yet powerful addition.

Timoeller merged commit 23d3177 into deepset-ai:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet